[PATCH] D146853: [Pseudo Probe] Placing .pseudoprobe section in the same comdat group with .text
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 16 09:51:16 PDT 2023
hoy added a comment.
In D146853#4428673 <https://reviews.llvm.org/D146853#4428673>, @MaskRay wrote:
> Thank you for mentioning lld/ELF, otherwise I may not notice this patch:) The part is not so related to the main functionality and I usually have a strong opinion on lld/test/ELF testing...
A test on lld side sounds good. I'll add it.
> Actually, for LLVM metadata sections, I think the convention is not to have a suffix like `.text.foo`. You may want to use `.pseudo_probe` without the suffix (`MCSectionELF::UniqueID`).
D152546 <https://reviews.llvm.org/D152546> is one implementation that treats `.pseudo_probe` as an independent section of `.text`, but after iterations we think they should be combined when it comes to deduplication and gc-sections, so I'm falling back to this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146853/new/
https://reviews.llvm.org/D146853
More information about the llvm-commits
mailing list