[PATCH] D146853: [Pseudo Probe] Placing .pseudoprobe section in the same comdat group with .text

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thank you for mentioning lld/ELF, otherwise I may not notice this patch:) The part is not so related to the main functionality and I usually have a strong opinion on lld/test/ELF testing...

Actually, for LLVM metadata sections, I think the convention is not to have a suffix like `.text.foo`. You may want to use `.pseudo_probe` without the suffix (`MCSectionELF::UniqueID`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146853/new/

https://reviews.llvm.org/D146853