[llvm] dddf66f - [OCaml] Rename link_modules' to link_modules
Alan Hu via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 16 06:19:08 PDT 2023
Author: Alan Hu
Date: 2023-06-16T09:18:26-04:00
New Revision: dddf66fd6577fd20302cf2e71b7fd78fbaed5c61
URL: https://github.com/llvm/llvm-project/commit/dddf66fd6577fd20302cf2e71b7fd78fbaed5c61
DIFF: https://github.com/llvm/llvm-project/commit/dddf66fd6577fd20302cf2e71b7fd78fbaed5c61.diff
LOG: [OCaml] Rename link_modules' to link_modules
Commit 434e956 renamed link_modules to link_modules' for unclear reasons.
Based on the commit's diff, the author possibly intended to have two
functions, link_modules to bind to LLVMLinkModules and link_modules' to
bind to LLVMLinkModules2. However, there is only one function. link_modules'
appears in LLVM 3.8 onwards.
Differential Revision: https://reviews.llvm.org/D153090
Added:
Modified:
llvm/bindings/ocaml/linker/llvm_linker.ml
llvm/bindings/ocaml/linker/llvm_linker.mli
llvm/test/Bindings/OCaml/linker.ml
Removed:
################################################################################
diff --git a/llvm/bindings/ocaml/linker/llvm_linker.ml b/llvm/bindings/ocaml/linker/llvm_linker.ml
index e61e8fcb5fc53..0952d0e640b50 100644
--- a/llvm/bindings/ocaml/linker/llvm_linker.ml
+++ b/llvm/bindings/ocaml/linker/llvm_linker.ml
@@ -10,5 +10,5 @@ exception Error of string
let () = Callback.register_exception "Llvm_linker.Error" (Error "")
-external link_modules' : Llvm.llmodule -> Llvm.llmodule -> unit
- = "llvm_link_modules"
+external link_modules : Llvm.llmodule -> Llvm.llmodule -> unit
+ = "llvm_link_modules"
diff --git a/llvm/bindings/ocaml/linker/llvm_linker.mli b/llvm/bindings/ocaml/linker/llvm_linker.mli
index ed8f0b38c4eb6..4300b3b512068 100644
--- a/llvm/bindings/ocaml/linker/llvm_linker.mli
+++ b/llvm/bindings/ocaml/linker/llvm_linker.mli
@@ -13,6 +13,6 @@
exception Error of string
-(** [link_modules' dst src] links [src] into [dst], raising [Error]
+(** [link_modules dst src] links [src] into [dst], raising [Error]
if the linking fails. The src module is destroyed. *)
-val link_modules' : Llvm.llmodule -> Llvm.llmodule -> unit
\ No newline at end of file
+val link_modules : Llvm.llmodule -> Llvm.llmodule -> unit
diff --git a/llvm/test/Bindings/OCaml/linker.ml b/llvm/test/Bindings/OCaml/linker.ml
index 81d7e9be34a90..6375be8636314 100644
--- a/llvm/test/Bindings/OCaml/linker.ml
+++ b/llvm/test/Bindings/OCaml/linker.ml
@@ -43,18 +43,18 @@ let test_linker () =
let m1 = make_module "one"
and m2 = make_module "two" in
- link_modules' m1 m2;
+ link_modules m1 m2;
dispose_module m1;
let m1 = make_module "one"
and m2 = make_module "two" in
- link_modules' m1 m2;
+ link_modules m1 m2;
dispose_module m1;
let m1 = make_module "one"
and m2 = make_module "one" in
try
- link_modules' m1 m2;
+ link_modules m1 m2;
failwith "must raise"
with Error _ ->
dispose_module m1
More information about the llvm-commits
mailing list