[PATCH] D153125: [lit] Likely fix for symlink path failures after D152709

[Tristan Labelle via Phabricator via llvm-commits]

MrTrillian created this revision.
MrTrillian added reviewers: rnk, compnerd, nlopes, Jake-Egan.
Herald added a project: All.
MrTrillian requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

D152709 <https://reviews.llvm.org/D152709> switched lit from using os.path.realpath to os.path.abspath since the former changed behavior in Python 3.8 and now resolves substitute drives used to shorten paths on Windows, causing us to run into MAX_PATH issues (the CMake-based build is already well-behaved with regard to this). Clang tests broke on a few architectures, where breaks are comparing paths with symlinks with path with expanded symlinks. I cannot repro this failure locally, but the likely issue is that llvm-lit still had an os.path.realpath, which would mismatch what the base lit.py now does.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153125

Files:
  llvm/utils/llvm-lit/llvm-lit.in


Index: llvm/utils/llvm-lit/llvm-lit.in
===================================================================
--- llvm/utils/llvm-lit/llvm-lit.in
+++ llvm/utils/llvm-lit/llvm-lit.in
@@ -8,7 +8,7 @@
 
 def map_config(source_dir, site_config):
     global config_map
-    source_dir = os.path.realpath(source_dir)
+    source_dir = os.path.abspath(source_dir)
     source_dir = os.path.normcase(source_dir)
     site_config = os.path.normpath(site_config)
     config_map[source_dir] = site_config


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153125.532102.patch
Type: text/x-patch
Size: 493 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230616/fa76324c/attachment.bin>