[PATCH] D153080: Emit DW_LLE_base_address + DW_LLE_offset_pairs instead of DW_LLE_start_length in debug_loclists section

Shubham Sandeep Rastogi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 16:51:04 PDT 2023


rastogishubham updated this revision to Diff 531946.
rastogishubham marked 3 inline comments as done.
rastogishubham added a comment.

Addressed Adrians comments:

1. Added a default initializer for the `BaseAddress` in `DWARFLocationExpressionsFragment`

2. Changed the ternery to an if statement when calculating the `BaseAddress` for a loclist fragment


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153080/new/

https://reviews.llvm.org/D153080

Files:
  llvm/include/llvm/DWARFLinker/DWARFLinker.h
  llvm/include/llvm/DWARFLinker/DWARFStreamer.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFLocationExpression.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DWARFLinker/DWARFStreamer.cpp
  llvm/lib/DWARFLinkerParallel/DWARFEmitterImpl.h
  llvm/test/tools/dsymutil/ARM/dwarf5-dwarf4-combination-macho.test
  llvm/test/tools/dsymutil/ARM/dwarf5-macho.test
  llvm/test/tools/dsymutil/X86/dwarf5-loclists.test
  llvm/test/tools/llvm-dwarfutil/ELF/X86/dwarf5-loclists.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153080.531946.patch
Type: text/x-patch
Size: 22531 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230615/b084b72f/attachment.bin>


More information about the llvm-commits mailing list