[PATCH] D153080: Emit DW_LLE_base_address + DW_LLE_offset_pairs instead of DW_LLE_start_length in debug_loclists section

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFLocationExpression.h:48
+  DWARFLocationExpressionsVector LinkedLocationExpression;
+  uint64_t BaseAddress;
+};
----------------
Maybe add an initializer here?
```
uint64_t BaseAddress = 0;
```


================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:1975
+    auto FirstLocation = (*OriginalLocations)[0];
+    LinkedLocationExpressionsFrag.BaseAddress =
+        Unit.getOrigUnit().getVersion() >= 5 && FirstLocation.Range
----------------
and then convert this to an `if (Unit.getOrigUnit().getVersion() >= 5 && FirstLocation.Range)`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153080/new/

https://reviews.llvm.org/D153080