[PATCH] D115559: AMDGPU: Propagate amdgpu-waves-per-eu with attributor

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:814
+  bool isValidState() const override {
+    return !Assumed.isEmptySet() && IntegerRangeState::isValidState();
+  }
----------------
jdoerfert wrote:
> Nit: Probably better to only redirect one level up (`AAAMDSizeRangeAttribute::isValidState()`)
> 
> FWIW:
> Empty should mean it's dead/misconfigured, no?
This was one of the struggles I forgot about. I didn't find a better way to express the valid bounds for this to infer. By default it covers 0, -1, which exceeds the maximum of 10 and it produces broken attributes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115559/new/

https://reviews.llvm.org/D115559