[PATCH] D115559: AMDGPU: Propagate amdgpu-waves-per-eu with attributor

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked 2 inline comments as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:686-688
   /// See AbstractAttribute::getState(...).
   IntegerRangeState &getState() override { return *this; }
   const IntegerRangeState &getState() const override { return *this; }
----------------
jdoerfert wrote:
> Nit: I doubt you need these. StateWrapper should provide them, IIRC.
They're already here so I'll try to delete separately


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:691
+  /// See AbstractAttribute::trackStatistics()
+  void trackStatistics() const override {}
 
----------------
jdoerfert wrote:
> FWIW, we should be able to track how often we manifested, hence improved, the ranges. I think that would be good to have.
It looks like you're supposed to implement this with macros private to AttributorAttributes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115559/new/

https://reviews.llvm.org/D115559