[PATCH] D152937: [RISCV] Document overview of vector psuedos [nfc]

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 02:49:46 PDT 2023


luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.h:323
+  from this representation.
+  * _TU - Can represent all three policy states.  If passthrough is
+  IMPLICIT_DEF, then represents "undefined".  Otherwise, policy operand
----------------
luke wrote:
> Not for this patch, but should we standardise the terminology of passthrough vs. merge throughout the backend and pick one? My weak preference would be for passthrough as it’s less confusing with vmerge etc. 
Not all TU pseudos have a policy operand (as of today). Should we document that without the policy operand it defaults to TUMU?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152937/new/

https://reviews.llvm.org/D152937



More information about the llvm-commits mailing list