[PATCH] D152821: [RISCV] Add support for Xcvmac extension in CV32E40P

[Lewis Revill via Phabricator via llvm-commits]

lewis-revill added a comment.

I would say that this looks good to me, I only have nitpicks rather than any real issues.

I wonder whether we should write the human-readable version (and thus filenames for tests) of the extension as `XCVmac` rather than `XCvmac`. The argument would be that currently I read this almost as an extension called `vmac` for a vendor with the initial `C`. Though given we are writing `XSfvcp` maybe keeping it as it is would match that better. If no other reviewers have a preference I would say it's up to you. Either way the predicate text `"'Xcvmac' (Multiply-Accumulate)"` should be changed to match whatever you decide.

The final thing that also doesn't matter too much is that maybe the test filename for valid MC output should end in `-valid.s`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152821/new/

https://reviews.llvm.org/D152821