[PATCH] D152821: [RISCV] Add support for Xcvmac extension in CV32E40P

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoXCvmac.td:119
+  // Signed 16x16 bit muls
+  def : InstAlias<"cv.muls $rd1, $rs1, $rs2", (CV_MULSN GPR:$rd1, GPR:$rs1, GPR:$rs2, 0), 0>;
+  def : InstAlias<"cv.mulhhs $rd1, $rs1, $rs2", (CV_MULHHSN GPR:$rd1, GPR:$rs1, GPR:$rs2, 0), 0>;
----------------
realqhc wrote:
> craig.topper wrote:
> > Why `Emit = 0` here?
> This is the current design for Core-V's GAS implementation. Also, setting it to non-zero may cause issue with cv.mulsn ..., ..., 0 but that may not exist apart from some test cases. 
Why are implementation details in gas at all relevant? This is LLVM not GNU binutils.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152821/new/

https://reviews.llvm.org/D152821