[PATCH] D152772: [LoopSink] Allow sinking to PHI-use

[Wenlei He via Phabricator via llvm-commits]

wenlei marked 3 inline comments as done.
wenlei added a comment.

Appreciate the quick review!



================
Comment at: llvm/test/Transforms/LICM/loopsink-phi.ll:48
+  %i2 = icmp eq i32 %arg, 0
+  br i1 %i2, label %.l.ret, label %.l.check.preheader
+
----------------
nikic wrote:
> You probably don't need this check and can just make `.j.check.preheader` the entry block?
indeed, removed `bb` and `ret block`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152772/new/

https://reviews.llvm.org/D152772