[PATCH] D152772: [LoopSink] Allow sinking to PHI-use

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/LICM/loopsink-phi.ll:48
+  %i2 = icmp eq i32 %arg, 0
+  br i1 %i2, label %.l.ret, label %.l.check.preheader
+
----------------
You probably don't need this check and can just make `.j.check.preheader` the entry block?


================
Comment at: llvm/test/Transforms/LICM/loopsink-phi.ll:98
+
+!0 = !{i32 2, !"Debug Info Version", i32 3}
+!1 = !{i32 1, !"ProfileSummary", !2}
----------------
Can drop this one from the module flags.


================
Comment at: llvm/test/Transforms/LICM/loopsink-phi.ll:129
+!30 = !{!"function_entry_count", i64 2}
+!31 = !{!"branch_weights", i32 2}
+!32 = !{!"branch_weights", i32 1, i32 201}
----------------
`!31` is unused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152772/new/

https://reviews.llvm.org/D152772