[PATCH] D152145: [InstSimplify] Fold all global variables with initializers

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 12:04:16 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

In D152145#4418621 <https://reviews.llvm.org/D152145#4418621>, @gandhi21299 wrote:

> Return unknown() for GV.hasExternalWeakLinkage(). Eliminate last two tests in objectsize_basic.ll

Could you please restore those two tests? They are still useful as negative tests, to make sure both are 0.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152145/new/

https://reviews.llvm.org/D152145



More information about the llvm-commits mailing list