[PATCH] D152145: [InstSimplify] Fold all global variables with initializers

[Anshil Gandhi via Phabricator via llvm-commits]

gandhi21299 updated this revision to Diff 531019.
gandhi21299 added a comment.

Return unknown() for GV.hasExternalWeakLinkage(). Eliminate last two tests in objectsize_basic.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152145/new/

https://reviews.llvm.org/D152145

Files:
  llvm/lib/Analysis/MemoryBuiltins.cpp
  llvm/test/Transforms/InstSimplify/gv-alloca-cmp.ll
  llvm/test/Transforms/LowerConstantIntrinsics/objectsize_basic.ll


Index: llvm/test/Transforms/LowerConstantIntrinsics/objectsize_basic.ll
===================================================================
--- llvm/test/Transforms/LowerConstantIntrinsics/objectsize_basic.ll
+++ llvm/test/Transforms/LowerConstantIntrinsics/objectsize_basic.ll
@@ -146,3 +146,23 @@
   %objsize = call i64 @llvm.objectsize.i64(ptr %ptr, i1 false, i1 true, i1 true)
   ret i64 %objsize
 }
+
+ at gv_weak = weak global i64 zeroinitializer, align 16
+
+define i32 @promote_with_objectsize_min_false() {
+; CHECK-LABEL: @promote_with_objectsize_min_false(
+; CHECK-NEXT:    ret i32 -1
+;
+  %size = call i32 @llvm.objectsize.i32.p0(ptr @gv_weak, i1 false, i1 false, i1 false)
+  ret i32 %size
+}
+
+define i32 @promote_with_objectsize_min_true() {
+; CHECK-LABEL: @promote_with_objectsize_min_true(
+; CHECK-NEXT:    ret i32 8
+;
+  %size = call i32 @llvm.objectsize.i32.p0(ptr @gv_weak, i1 true, i1 false, i1 false)
+  ret i32 %size
+}
+
+declare i32 @llvm.objectsize.i32.p0(ptr, i1, i1, i1)
Index: llvm/test/Transforms/InstSimplify/gv-alloca-cmp.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/InstSimplify/gv-alloca-cmp.ll
@@ -0,0 +1,46 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
+; RUN: opt < %s -passes=instsimplify -S | FileCheck %s
+
+ at gv = global i64 zeroinitializer, align 16
+
+define i1 @cmp_gv_alloca() {
+; CHECK-LABEL: define i1 @cmp_gv_alloca() {
+; CHECK-NEXT:    ret i1 false
+;
+  %alloca = alloca i64, align 8
+  %cmp = icmp eq ptr %alloca, @gv
+  ret i1 %cmp
+}
+
+ at gv_externally_init = externally_initialized global i64 zeroinitializer, align 16
+
+define i1 @cmp_gv_alloca_extern_init() {
+; CHECK-LABEL: define i1 @cmp_gv_alloca_extern_init() {
+; CHECK-NEXT:    ret i1 false
+;
+  %alloca = alloca i64, align 8
+  %cmp = icmp eq ptr %alloca, @gv_externally_init
+  ret i1 %cmp
+}
+
+ at const_gv = protected addrspace(4) externally_initialized global [4096 x i64] zeroinitializer, align 16
+define i1 @cmp_gv_alloca_cast() {
+; CHECK-LABEL: define i1 @cmp_gv_alloca_cast() {
+; CHECK-NEXT:    ret i1 false
+;
+  %alloca = alloca i64, align 8, addrspace(5)
+  %cast.alloca = addrspacecast ptr addrspace(5) %alloca to ptr
+  %cmp = icmp eq ptr %cast.alloca, addrspacecast (ptr addrspace(4) @const_gv to ptr)
+  ret i1 %cmp
+}
+
+ at gv_weak = weak global i64 zeroinitializer, align 16
+
+define i1 @cmp_gv_weak_alloca() {
+; CHECK-LABEL: define i1 @cmp_gv_weak_alloca() {
+; CHECK-NEXT:    ret i1 false
+;
+  %alloca = alloca i64, align 8
+  %cmp = icmp eq ptr %alloca, @gv_weak
+  ret i1 %cmp
+}
Index: llvm/lib/Analysis/MemoryBuiltins.cpp
===================================================================
--- llvm/lib/Analysis/MemoryBuiltins.cpp
+++ llvm/lib/Analysis/MemoryBuiltins.cpp
@@ -826,7 +826,9 @@
 }
 
 SizeOffsetType ObjectSizeOffsetVisitor::visitGlobalVariable(GlobalVariable &GV){
-  if (!GV.hasDefinitiveInitializer())
+  if (GV.hasExternalWeakLinkage() ||
+      ((!GV.hasInitializer() || GV.isInterposable()) &&
+       Options.EvalMode != ObjectSizeOpts::Mode::Min))
     return unknown();
 
   APInt Size(IntTyBits, DL.getTypeAllocSize(GV.getValueType()));


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152145.531019.patch
Type: text/x-patch
Size: 3223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230613/26330bb8/attachment.bin>