[PATCH] D152843: Switch magic numbers to library functions in fixup

Daniel Hoekwater via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 11:08:01 PDT 2023


dhoekwater created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
dhoekwater requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Using masks and bounds that are magic numbers
means that defects in bounds checking and offset
masking are subtle and hard to detect.
https://reviews.llvm.org/D152841 is an example
of this type of defect. Switching to clearly
readable library functions makes defects less
obfuscated.

Depends on D152841 <https://reviews.llvm.org/D152841>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152843

Files:
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152843.530995.patch
Type: text/x-patch
Size: 5577 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230613/5cddab00/attachment.bin>


More information about the llvm-commits mailing list