[PATCH] D152022: [CodeGen] Add support for reductions in ComplexDeinterleaving pass
Nicholas Guy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 12 04:19:03 PDT 2023
NickGuy accepted this revision.
NickGuy added a comment.
This revision is now accepted and ready to land.
LGTM, nice work
================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:1752
+ Value *ReplacementNode;
+ switch (Node->Operation) {
+ case ComplexDeinterleavingOperation::CAdd:
----------------
Nit: May be worth adding a default case for this switch. Something simple like the following
```
default:
llvm_unreachable("Unhandled case in ComplexDeinterleavingGraph::replaceNode");
break;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152022/new/
https://reviews.llvm.org/D152022
More information about the llvm-commits
mailing list