[PATCH] D152241: [CaptureTracking] Do not capture equality compares of same object

Joshua Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 11 16:00:50 PDT 2023


caojoshua added a comment.

A PR <https://github.com/rust-lang/rust/pull/112516> was submitted to rust to change pointer inductions to index inductions for array allocations, which if merged, eliminates my main motivation for this patch.

I'm questioning the benefits of this patch. GEP inductions are certainly common, but comparisons against a GEP with (start, end) pointers are much less common when you can just iterate over indices. I don't have another real world example that supports this patch. @nikic any opinions, do you think this patch is a good enhancement to LLVM?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152241/new/

https://reviews.llvm.org/D152241



More information about the llvm-commits mailing list