[PATCH] D152241: [CaptureTracking] Do not capture equality compares of same object

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/CaptureTracking.cpp:91
+      NewV = Visit(GEP->getPointerOperand());
+    if (auto *PN = dyn_cast<PHINode>(V)) {
+      // We can look through PHIs if each underlying value has the same
----------------
nikic wrote:
> If we handle phis, we should also handle selects.
We also need to limit recursion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152241/new/

https://reviews.llvm.org/D152241