[PATCH] D152540: [MC][MachO]Do not emit DWARF for no-personality case
Thorsten via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 9 20:55:22 PDT 2023
tschuett added inline comments.
================
Comment at: llvm/lib/MC/MCAsmBackend.cpp:125
+
+ assert(Sym->isMachO());
+ StringRef name = Sym->getName();
----------------
jyknight wrote:
> tschuett wrote:
> > Could you please turn the assert into an if-statement?
> Can you please clarify the purpose of your request? Refer to previous discussion thread here as to why this was changed, and if you disagree, please explain why.
In release mode, the assert cannot fire. It is useless. It only helps you during development.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152540/new/
https://reviews.llvm.org/D152540
More information about the llvm-commits
mailing list