[PATCH] D152540: [MC][MachO]Do not emit DWARF for no-personality case

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 9 14:10:26 PDT 2023


jyknight added inline comments.


================
Comment at: llvm/lib/MC/MCAsmBackend.cpp:125
+
+  assert(Sym->isMachO());
+  StringRef name = Sym->getName();
----------------
tschuett wrote:
> Could you please turn the assert into an if-statement?
Can you please clarify the purpose of your request? Refer to previous discussion thread here as to why this was changed, and if you disagree, please explain why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152540/new/

https://reviews.llvm.org/D152540



More information about the llvm-commits mailing list