[PATCH] D152039: [RISCV] Remove uses of RISCVII::hasMergeOp from RISCVDAGToDAGISel.cpp
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 5 15:35:13 PDT 2023
craig.topper added a comment.
In D152039#4396229 <https://reviews.llvm.org/D152039#4396229>, @reames wrote:
> Should we introduce a separate hasTiedDest utility? (With possibly a better chosen name?) I think having that might help clarify the difference between the check being performed here and the hasMergeOp routine. I have to admit I'm not completely following your semantic difference, so having a place to explain that in comments might help.
Maybe the name `hasMergeOp` is the problem because the documentation did say what it meant.
// Does this instruction have a merge operand that must be removed when
// converting to MCInst. It will be the first explicit use operand. Used by
// RVV Pseudos.
HasMergeOpShift = ForceTailAgnosticShift + 1,
HasMergeOpMask = 1 << HasMergeOpShift,
I think I can remove it from RISCVMCInstLowering too so the distinction won't matter soon.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152039/new/
https://reviews.llvm.org/D152039
More information about the llvm-commits
mailing list