[PATCH] D152039: [RISCV] Remove uses of RISCVII::hasMergeOp from RISCVDAGToDAGISel.cpp

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 09:22:55 PDT 2023


reames added a comment.

Should we introduce a separate hasTiedDest utility?  (With possibly a better chosen name?)  I think having that might help clarify the difference between the check being performed here and the hasMergeOp routine.  I have to admit I'm not completely following your semantic difference, so having a place to explain that in comments might help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152039/new/

https://reviews.llvm.org/D152039



More information about the llvm-commits mailing list