[PATCH] D152039: [RISCV] Remove uses of RISCVII::hasMergeOp from RISCVDAGToDAGISel.cpp

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:3193
+      MCID.getOperandConstraint(MCID.getNumDefs(), MCOI::TIED_TO) == 0;
+  assert(UseTUPseudo == HasTiedDest && RISCVII::hasDummyMaskOp(TSFlags) &&
          "Unexpected pseudo to transform to");
----------------
Might this result in an not-used-in-release warning? I'm not sure what the current idiom is - `[[maybe_unused]]` or cast to void?


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:3250
 
   // Skip if True has merge operand.
+  const MCInstrDesc &TrueMCID = TII->get(TrueOpc);
----------------
Comment needs updating


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152039/new/

https://reviews.llvm.org/D152039