[PATCH] D152100: [libunwind] Removes CMake work-arounds.

Mark de Wever via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 4 08:41:56 PDT 2023


Mordante created this revision.
Herald added a subscriber: mstorsjo.
Herald added a project: All.
Mordante requested review of this revision.
Herald added projects: LLVM, libunwind.
Herald added subscribers: libcxx-commits, llvm-commits.
Herald added a reviewer: libunwind.

CMake older than 3.20.0 is no longer supported.
This removes work-arounds for no longer supported versions.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152100

Files:
  libunwind/src/CMakeLists.txt


Index: libunwind/src/CMakeLists.txt
===================================================================
--- libunwind/src/CMakeLists.txt
+++ libunwind/src/CMakeLists.txt
@@ -26,14 +26,6 @@
     UnwindRegistersSave.S
     )
 
-# See add_asm_sources() in compiler-rt for explanation of this workaround.
-# CMake doesn't work correctly with assembly on AIX. Workaround by compiling
-# as C files as well.
-if((APPLE AND CMAKE_VERSION VERSION_LESS 3.19) OR
-   (MINGW AND CMAKE_VERSION VERSION_LESS 3.17))
-  set_source_files_properties(${LIBUNWIND_ASM_SOURCES} PROPERTIES LANGUAGE C)
-endif()
-
 set(LIBUNWIND_HEADERS
     AddressSpace.hpp
     assembly.h


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152100.528223.patch
Type: text/x-patch
Size: 653 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230604/c55f25a1/attachment.bin>


More information about the llvm-commits mailing list