[PATCH] D146776: [llvm] Preliminary fat-lto-objects support

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

this basically lgtm



================
Comment at: llvm/lib/Bitcode/Writer/EmbedBitcodePass.cpp:30-37
+static cl::opt<bool> ClIsThinLTO("embed-bitcode-thinlto",
+                                 cl::desc("Enable ThinLTO bitcode generation"),
+                                 cl::Hidden, cl::init(false));
+
+static cl::opt<bool>
+    ClEmitLTOSummary("embed-bitcode-emit-summary",
+                     cl::desc("Emit summaries in the FatLTO section"),
----------------
these should be unnecessary with the newly added pass params, e.g. `-passes=embed-bitcode<emit-summary>`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776