[PATCH] D146776: [llvm] Preliminary fat-lto-objects support

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 09:04:36 PDT 2023


paulkirth added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1480
 
+  // TODO: once D148010 lands, we can simplify this
+  MPM.addPass(EmbedBitcodePass(ThinLTO, EmitSummary,
----------------
aeubanks wrote:
> this comment is obsolete now
I was thinking once that patch lands we can take the `ThinOrFullLTOPhase` direcly and avoid the branch, but maybe it still makes sense to leave this as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776



More information about the llvm-commits mailing list