[PATCH] D151562: [ValueTracking] Remove ORE argument (NFC-ish)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 26 06:23:35 PDT 2023


nikic created this revision.
nikic added reviewers: arsenm, RKSimon, foad, goldstein.w.n.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
nikic requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

The ORE argument threaded through ValueTracking is used only in a single, untested place. It is also essentially never passed: The only places that do so have been added very recently as part of the KnownFPClass migration, which is vanishingly unlikely to hit this code path. Remove this effectively dead argument.

(Background motivation is that I'd like to unify the Query between ValueTracking and InstSimplify, and this is one of the discrepancies.)


https://reviews.llvm.org/D151562

Files:
  llvm/include/llvm/Analysis/ValueTracking.h
  llvm/include/llvm/Transforms/InstCombine/InstCombiner.h
  llvm/lib/Analysis/ValueTracking.cpp
  llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151562.526041.patch
Type: text/x-patch
Size: 19238 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230526/4376468e/attachment.bin>


More information about the llvm-commits mailing list