[PATCH] D149743: [RISCV][CodeGen] Support Zdinx on RV32 codegen

Shao-Ce SUN via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 25 21:59:00 PDT 2023


sunshaoce added a comment.

In D149743#4371235 <https://reviews.llvm.org/D149743#4371235>, @jrtc27 wrote:

> I don’t see any tests for loading from ~~globals and~~ constant pools, so there’s no coverage of that code?
>
> (EDIT: Globals are indeed there, but only for position-dependent medlow code, not sure why my search for %lo earlier didn't work)

I added a test for Constant Pool in D151534 <https://reviews.llvm.org/D151534>.  If there are any tests that haven't been covered yet, can you help provide them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149743/new/

https://reviews.llvm.org/D149743



More information about the llvm-commits mailing list