[PATCH] D151082: [GuardUtils] Allow intermmediate blocks between widenable branch and deopt block

[Anna Thomas via Phabricator via llvm-commits]

anna added inline comments.


================
Comment at: llvm/lib/Analysis/GuardUtils.cpp:41
+        return true;
+      if (Insn.mayHaveSideEffects())
+        return false;
----------------
anna wrote:
> JFI: As part of the follow-up where the check is for profitability, rather than this being needed for functional correctness, we can collapse this entire block into `IsBlockFollowedByDeoptOrUnreachable` (since we need not check for `mayHaveSideEffects`). 
> 
that API has also the benefit it has a cut-off for successor walking: MaxDeoptOrUnreachableSuccessorCheckDepth. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151082/new/

https://reviews.llvm.org/D151082