[PATCH] D151082: [GuardUtils] Allow intermmediate blocks between widenable branch and deopt block

[Anna Thomas via Phabricator via llvm-commits]

anna accepted this revision.
anna added a comment.
This revision is now accepted and ready to land.

LGTM. I agree we can do the refactoring to profitability as follow-up.



================
Comment at: llvm/lib/Analysis/GuardUtils.cpp:41
+        return true;
+      if (Insn.mayHaveSideEffects())
+        return false;
----------------
JFI: As part of the follow-up where the check is for profitability, rather than this being needed for functional correctness, we can collapse this entire block into `IsBlockFollowedByDeoptOrUnreachable` (since we need not check for `mayHaveSideEffects`). 



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151082/new/

https://reviews.llvm.org/D151082