[PATCH] D151188: [lld] Find resource and lib dir
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 24 08:59:07 PDT 2023
rnk added a comment.
> While it would be better if we didn't need to add this logic to lld at all, I don't think we can change the paradigm that Microsoft has with its toolchain already. There is already precedent for this - if you look in the WindowsDriver library, we already probed for the visual studio installation and added those default search paths in lld. This expands that functionality to add (less complicated) logic to find the toolchain library paths. So I don't think this is way out of line.
So, I agree that if we have already gone down the path of discovering the location of the MSVC installation and recomputing the architecture and version specific paths to libraries, I don't have a principled reason for not doing the same thing for Clang.
It will, however, be brittle. Users customize their triple spellings. It is not at all straightforward. Perhaps we can live with that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151188/new/
https://reviews.llvm.org/D151188
More information about the llvm-commits
mailing list