[PATCH] D151288: [MIPS] Check if register is non-null before calling isSuperOrSubRegisterEq (NFCI)

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added a comment.

In D151288#4367391 <https://reviews.llvm.org/D151288#4367391>, @wzssyqa wrote:

> I noticed there are some lines like:
>
>   2955     unsigned TmpReg = DstReg;
>   2956     if (UseSrcReg &&
>   2957         getContext().getRegisterInfo()->isSuperOrSubRegisterEq(DstReg,
>   2958                                                                SrcReg)) {
>   2959       // If $rs is the same as $rd, we need to use AT.
>   2960       // If it is not available we exit.
>   2961       unsigned ATReg = getATReg(IDLoc);
>   2962       if (!ATReg)
>   2963         return true;
>   2964       TmpReg = ATReg;
>   2965     }
>
> Is `UseSrcReg` OK for here?

I honestly don't know :) Sounds reasonable, let's try it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151288/new/

https://reviews.llvm.org/D151288