[PATCH] D151288: [MIPS] Check if register is non-null before calling isSuperOrSubRegisterEq (NFCI)

YunQiang Su via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 01:21:05 PDT 2023


wzssyqa added a comment.

I noticed there are some lines like:

  2955     unsigned TmpReg = DstReg;
  2956     if (UseSrcReg &&
  2957         getContext().getRegisterInfo()->isSuperOrSubRegisterEq(DstReg,
  2958                                                                SrcReg)) {
  2959       // If $rs is the same as $rd, we need to use AT.
  2960       // If it is not available we exit.
  2961       unsigned ATReg = getATReg(IDLoc);
  2962       if (!ATReg)
  2963         return true;
  2964       TmpReg = ATReg;
  2965     }

Is `UseSrcReg` OK for here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151288/new/

https://reviews.llvm.org/D151288



More information about the llvm-commits mailing list