[PATCH] D150929: [RISCV][BF16] Enable __bf16 for riscv targets

Tue May 23 19:19:03 PDT 2023

joshua-arch1 added a comment.

In D150929#4361151 <https://reviews.llvm.org/D150929#4361151>, @asb wrote:

> I feel (IMHO) this is jumping to the endpoint a bit - the usual route for something like this is:
>
> - MC layer support
> - LLVM codegen support (and tests!)
> - Any needed Clang support
>
> I was hoping to push out some patches related to zfbfmin tests+codegen today but might time-out (if so, I'll return to it tomorrow).
>
> I think the tentative conclusion of https://discourse.llvm.org/t/rfc-c-23-p1467r9-extended-floating-point-types-and-standard-names/70033 is to make __bf16_t an arithmetic type on all targets - I'd recommend keeping an eye on https://reviews.llvm.org/D150913 (and ideally helping to review it), as that's bound to interact with this patch.

Have you started the codegen part yet? I have basically tried but it may be a little troublesome since we use FPR16 for both fp16 and bf16. During instruction selection, it will be difficult to match those instructions fp16 and bf16 share.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150929/new/

https://reviews.llvm.org/D150929