[PATCH] D150990: [split-file] Add flags to support comments and adding extension to output files

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

> I go into more details on motivation in Discourse thread.

Thanks for the link, but it seems that the thread doesn't give examples how `--allow-comments` and `--add-file-extension` are supposed to be used.

> `// dr164: 16 becomes //--- dr164: 16, which produces dr164.cpp file with the corresponding test.`

I am confused by this comment. Does the option ignore everything starting from the `:`? Why?
The Discourse thread gives a link to https://github.com/llvm/llvm-project/blob/main/clang/test/CXX/drs/dr5xx.cpp which uses this notation, but the discourse thread doesn't elaborate on the syntax. This kind of detail is actually what I expect from the commit message/Phabricator summary, instead of some information embedded in a very long C++ DR specific forum post.

For testing, use `llvm/test/tools/split-file/` and `ninja check-llvm-tools-split-file`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150990/new/

https://reviews.llvm.org/D150990