[PATCH] D150990: [split-file] Add flags to support comments and adding extension to output files

[Vlad Serebrennikov via Phabricator via llvm-commits]

Endill marked 2 inline comments as done.
Endill added a comment.

In D150990#4362447 <https://reviews.llvm.org/D150990#4362447>, @aaron.ballman wrote:

> Should this also update https://llvm.org/docs/TestingGuide.html#extra-files so we have some public documentation for the functionality?

I don't think the features I implements blend in the motivating example of "Extra files" section.
I'd say we deserve our own subsection, e.g. "Grouping small tests in a single file", where we can showcase our use case, but that requires lit side of things (`%{for-each-file}`) to be merged as well. So I'd like to address this in a separate patch. Feel free to remind me if I get lazy or forget about this :)



================
Comment at: llvm/utils/split-file/split-file.cpp:138-139
     sys::path::append(partPath, output, keyValue.first);
+    if (!addFileExtension.empty()) {
+      partPath.append(".");
+      partPath.append(addFileExtension.getValue());
----------------
aaron.ballman wrote:
> Should we be kind and look at `addFileExtension.getValue()[0]` to see if it's `.` already? e.g., the user does: `--add-file-extension=.cpp`
That's a good suggstion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150990/new/

https://reviews.llvm.org/D150990