[PATCH] D150644: [lld][ELF] Implement –print-memory-usage

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/linkerscript/print-memory-usage1.s:3
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+# RUN: echo "MEMORY { \
----------------
phosek wrote:
> peter.smith wrote:
> > More recent tests have used the `split-file` command to have the linker script and the assembler in the same file without needing a large echo command. This makes a bit easier to edit.
> > 
> > Will be worth checking with MaskRay to see his preference is though. 
> I was following the existing `memory*.s` test cases for consistency but I'm fine changing these to use `split-file` if that's @MaskRay's preference?
The linker script seems too long. Using split-file should be clearer for this test.

And consider combining `print-memory-usage1.s` and `print-memory-usage2.s` and `print-memory-usage3.s` into one file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150644/new/

https://reviews.llvm.org/D150644