[PATCH] D150644: [lld][ELF] Implement –print-memory-usage

Tue May 23 01:47:28 PDT 2023

phosek added inline comments.

================
Comment at: lld/test/ELF/linkerscript/print-memory-usage1.s:3
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+# RUN: echo "MEMORY { \
----------------
peter.smith wrote:
> More recent tests have used the `split-file` command to have the linker script and the assembler in the same file without needing a large echo command. This makes a bit easier to edit.
> 
> Will be worth checking with MaskRay to see his preference is though. 
I was following the existing `memory*.s` test cases for consistency but I'm fine changing these to use `split-file` if that's @MaskRay's preference?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150644/new/

https://reviews.llvm.org/D150644