[PATCH] D151187: [doc] Add casting style preference to coding standards

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 03:20:28 PDT 2023


mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM, but you should probably get a least another one.

> I agree with safety and grepable. However, I disagree with cast to void. I believe there is no final decision between cast to void and [[maybe_unused]].

Are you arguing that casting to void should be forbidden right now? 
The new documentation is not saying anything about a preference, it merely avoids introducing a new prohibition about the `(void)` pattern, which to me seems to match existing practices.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151187/new/

https://reviews.llvm.org/D151187



More information about the llvm-commits mailing list