[PATCH] D151187: [doc] Add casting style preference to coding standards
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 23 01:35:37 PDT 2023
jhenderson added a comment.
In D151187#4363557 <https://reviews.llvm.org/D151187#4363557>, @tschuett wrote:
> I agree with safety and grepable. However, I disagree with cast to void. I believe there is no final decision between cast to void and [[maybe_unused]].
I'm happy to drop the bit about casting to void (I have no particular thoughts on `[[maybe_unused]]` at this time). I only added it for clarity, because the section immediately above explicitly says to cast to void for assertions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151187/new/
https://reviews.llvm.org/D151187
More information about the llvm-commits
mailing list