[PATCH] D149942: [IR] Drop const in DILocation::getMergedLocation

Christian Ulmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 23:08:16 PDT 2023


Dinistro added a comment.

In D149942#4362991 <https://reviews.llvm.org/D149942#4362991>, @dblaikie wrote:

> "MLIR's import"? Did this allow the removal of some const_casts in MLIR? (could you link to those patches here - be good to have the context connected here)

I was referring to the LLVM IR import into MLIR. `DebugTranslation.cpp`, which was changed in this revision is a part of this. The removal of constness not only drops the need for `const_cast` in this file, but also affect down stream users of the location translation.
For now, there are no other revisions we can link here, as this is the only place where this is used in MLIR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149942/new/

https://reviews.llvm.org/D149942



More information about the llvm-commits mailing list