[PATCH] D149942: [IR] Drop const in DILocation::getMergedLocation

Mon May 22 18:02:19 PDT 2023

dblaikie added a comment.

In D149942#4359606 <https://reviews.llvm.org/D149942#4359606>, @Dinistro wrote:

> In D149942#4351081 <https://reviews.llvm.org/D149942#4351081>, @dblaikie wrote:
>
>> any particular examples of these problematic const_casts? (is there a subsequent cleanup patch showing the motivation/value in this patch?)
>
> `DILocation` has a special relationship with constness. This revision removes the traces of constness in MLIR's import, which was the main motivation for this cleanup.

"MLIR's import"? Did this allow the removal of some const_casts in MLIR? (could you link to those patches here - be good to have the context connected here)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149942/new/

https://reviews.llvm.org/D149942