[PATCH] D151179: [CodeGenPrepare][NFC] Replace GEP's offset computation with collectOffset

[luxufan via Phabricator via llvm-commits]

StephenFan created this revision.
StephenFan added reviewers: nikic, craig.topper.
Herald added a subscriber: hiraditya.
Herald added a project: All.
StephenFan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151179

Files:
  llvm/lib/CodeGen/CodeGenPrepare.cpp


Index: llvm/lib/CodeGen/CodeGenPrepare.cpp
===================================================================
--- llvm/lib/CodeGen/CodeGenPrepare.cpp
+++ llvm/lib/CodeGen/CodeGenPrepare.cpp
@@ -4687,46 +4687,28 @@
   case Instruction::GetElementPtr: {
     // Scan the GEP.  We check it if it contains constant offsets and at most
     // one variable offset.
-    int VariableOperand = -1;
     unsigned VariableScale = 0;
+    Value *VariableOperand = nullptr;
 
-    int64_t ConstantOffset = 0;
-    gep_type_iterator GTI = gep_type_begin(AddrInst);
-    for (unsigned i = 1, e = AddrInst->getNumOperands(); i != e; ++i, ++GTI) {
-      if (StructType *STy = GTI.getStructTypeOrNull()) {
-        const StructLayout *SL = DL.getStructLayout(STy);
-        unsigned Idx =
-            cast<ConstantInt>(AddrInst->getOperand(i))->getZExtValue();
-        ConstantOffset += SL->getElementOffset(Idx);
-      } else {
-        TypeSize TS = DL.getTypeAllocSize(GTI.getIndexedType());
-        if (TS.isNonZero()) {
-          // The optimisations below currently only work for fixed offsets.
-          if (TS.isScalable())
-            return false;
-          int64_t TypeSize = TS.getFixedValue();
-          if (ConstantInt *CI =
-                  dyn_cast<ConstantInt>(AddrInst->getOperand(i))) {
-            const APInt &CVal = CI->getValue();
-            if (CVal.getSignificantBits() <= 64) {
-              ConstantOffset += CVal.getSExtValue() * TypeSize;
-              continue;
-            }
-          }
-          // We only allow one variable index at the moment.
-          if (VariableOperand != -1)
-            return false;
+    APInt Offset(DL.getIndexTypeSizeInBits(AddrInst->getOperand(0)->getType()),
+                 0);
+    MapVector<Value *, APInt> VariableOffsets;
+    cast<GEPOperator>(AddrInst)->collectOffset(DL, Offset.getBitWidth(),
+                                               VariableOffsets, Offset);
 
-          // Remember the variable index.
-          VariableOperand = i;
-          VariableScale = TypeSize;
-        }
-      }
+    // We only allow one variable index at the moment.
+    if (VariableOffsets.size() > 1)
+      return false;
+
+    if (VariableOffsets.size() == 1) {
+      VariableOperand = VariableOffsets.begin()->first;
+      VariableScale = VariableOffsets.begin()->second.getZExtValue();
     }
 
+    int64_t ConstantOffset = Offset.getSExtValue();
     // A common case is for the GEP to only do a constant offset.  In this case,
     // just add it to the disp field and check validity.
-    if (VariableOperand == -1) {
+    if (!VariableOperand) {
       AddrMode.BaseOffs += ConstantOffset;
       if (matchAddr(AddrInst->getOperand(0), Depth + 1)) {
           if (!cast<GEPOperator>(AddrInst)->isInBounds())
@@ -4782,8 +4764,7 @@
     }
 
     // Match the remaining variable portion of the GEP.
-    if (!matchScaledValue(AddrInst->getOperand(VariableOperand), VariableScale,
-                          Depth)) {
+    if (!matchScaledValue(VariableOperand, VariableScale, Depth)) {
       // If it couldn't be matched, try stuffing the base into a register
       // instead of matching it, and retrying the match of the scale.
       AddrMode = BackupAddrMode;
@@ -4793,8 +4774,7 @@
       AddrMode.HasBaseReg = true;
       AddrMode.BaseReg = AddrInst->getOperand(0);
       AddrMode.BaseOffs += ConstantOffset;
-      if (!matchScaledValue(AddrInst->getOperand(VariableOperand),
-                            VariableScale, Depth)) {
+      if (!matchScaledValue(VariableOperand, VariableScale, Depth)) {
         // If even that didn't work, bail.
         AddrMode = BackupAddrMode;
         AddrModeInsts.resize(OldSize);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151179.524561.patch
Type: text/x-patch
Size: 3714 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230523/02f57157/attachment.bin>