[PATCH] D149166: [RISCV] Try to perform select => binop combines when conditional operations are available

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 20:32:26 PDT 2023


craig.topper added a comment.

In D149166#4298860 <https://reviews.llvm.org/D149166#4298860>, @asb wrote:

> In D149166#4297768 <https://reviews.llvm.org/D149166#4297768>, @craig.topper wrote:
>
>> I had wondered if it made sense to handle Zicond/XventanaCondOps in LowerSelect by creating RISCV::CZERO_EQZ/CZERO_NEZ opcodes. Would cut down on the number of isel patterns.
>
> Thanks, that's not an option I'd explored but I like that it might provide more uniformity for the condops vs non-condops. Let me have a play with that alternative.

Reverse ping. Any update on this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149166/new/

https://reviews.llvm.org/D149166



More information about the llvm-commits mailing list