[PATCH] D76354: [RISCV][GlobalISel] Legalize types for ALU operations

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 13:30:50 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp:60
+    }
+  } else
+    getActionDefinitionsBuilder({G_MUL, G_SDIV, G_SREM, G_UDIV, G_UREM})
----------------
Braces 


================
Comment at: llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp:75-76
+
+    getActionDefinitionsBuilder(G_UMULH).legalFor({XLenLLT}).clampScalar(
+        0, XLenLLT, XLenLLT);
+  }
----------------
I think this is a really ugly way to wrap legalize rules and clang-format is wrong


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76354/new/

https://reviews.llvm.org/D76354



More information about the llvm-commits mailing list