[PATCH] D150816: [llvm-mca][RISCV] Fix llvm-mca RISCVInstrument memory leak

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 11:11:46 PDT 2023


myhsu added a comment.

In D150816#4356378 <https://reviews.llvm.org/D150816#4356378>, @michaelmaitland wrote:

> Fix memory leaks. This change now passes valgrind with no leaks.

Nice! generally LGTM, I only have a minor comment on the dtor of CodeRegionGenerator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150816/new/

https://reviews.llvm.org/D150816



More information about the llvm-commits mailing list