[PATCH] D150816: [llvm-mca][RISCV] Fix llvm-mca RISCVInstrument memory leak

[Michael Maitland via Phabricator via llvm-commits]

michaelmaitland added inline comments.


================
Comment at: llvm/tools/llvm-mca/CodeRegionGenerator.h:93
   CodeRegionGenerator() {}
-  virtual ~CodeRegionGenerator();
+  virtual ~CodeRegionGenerator() = default;
 };
----------------
myhsu wrote:
> was this default dtor causing any issue?
This dtor was not causing an issue since it is implemented and "Anchors" in the .cpp file. That is why I removed this change with an update to this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150816/new/

https://reviews.llvm.org/D150816