[PATCH] D150816: [llvm-mca][RISCV] Fix llvm-mca RISCVInstrument memory leak

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 11:10:00 PDT 2023


myhsu added inline comments.


================
Comment at: llvm/tools/llvm-mca/CodeRegionGenerator.h:93
   CodeRegionGenerator() {}
-  virtual ~CodeRegionGenerator();
+  virtual ~CodeRegionGenerator() = default;
 };
----------------
was this default dtor causing any issue?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150816/new/

https://reviews.llvm.org/D150816



More information about the llvm-commits mailing list