[PATCH] D150855: MachineCombiner: consider all uses in getLatency()

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 requested changes to this revision.
barannikov88 added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/CodeGen/MachineCombiner.cpp:224
         continue;
-      if (!MO.isUse())
-        continue;
----------------
This change is not correct. `MI->uses()` is misnomer, it returns everything apart explicit defs. I.e. it returns explicit uses, implicit uses, //and// implicit defs.




================
Comment at: llvm/lib/CodeGen/MachineCombiner.cpp:279
       continue;
-    if (!MO.isDef())
-      continue;
----------------
This, too. MI->defs()` returns only //explicit// defs, it does not include implicit ones.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150855/new/

https://reviews.llvm.org/D150855